CI/CD mit ABAP Cloud

┌─────────────────────────────────────────────────────────────────────────┐
│                        CI/CD Pipeline für ABAP Cloud                     │
│                                                                          │
│  ┌─────────┐   ┌─────────┐   ┌─────────┐   ┌─────────┐   ┌─────────┐   │
│  │  Code   │   │  Build  │   │  Test   │   │ Quality │   │ Deploy  │   │
│  │  Push   │──▶│  Check  │──▶│  Stage  │──▶│  Gate   │──▶│  Stage  │   │
│  └─────────┘   └─────────┘   └─────────┘   └─────────┘   └─────────┘   │
│       │             │             │             │             │         │
│       │             │             │             │             │         │
│       ▼             ▼             ▼             ▼             ▼         │
│   Git Push      Syntax &     ABAP Unit      ATC Checks    gCTS Pull    │
│   Trigger       Activation   Tests          Code Review   Transport    │
│                              Integration    Coverage      Release      │
│                              Tests          Security                   │
│                                                                          │
└─────────────────────────────────────────────────────────────────────────┘

┌────────────────────────────────────────────────────────────────┐
│                   SAP CI/CD Service                              │
│                                                                  │
│  ┌──────────────┐  ┌──────────────┐  ┌──────────────┐          │
│  │   Pipeline   │  │    Jobs &    │  │   Artifact   │          │
│  │   Editor     │  │    Stages    │  │   Storage    │          │
│  └──────────────┘  └──────────────┘  └──────────────┘          │
│                                                                  │
│  ┌──────────────┐  ┌──────────────┐  ┌──────────────┐          │
│  │  Credentials │  │   Webhooks   │  │   Logs &     │          │
│  │   Manager    │  │   & Trigger  │  │   Reports    │          │
│  └──────────────┘  └──────────────┘  └──────────────┘          │
│                                                                  │
│  Unterstützte Szenarien:                                        │
│  • SAP Fiori in SAP BTP Cloud Foundry                          │
│  • SAP Cloud Application Programming Model (CAP)               │
│  • ABAP Environment (SAP BTP)                                  │
│  • gCTS Integration                                             │
│                                                                  │
└────────────────────────────────────────────────────────────────┘

# .pipeline/config.yml für ABAP Environment
general:
  buildTool: "abap"
  abapSystemUrl: "https://my-system.abap.eu10.hana.ondemand.com"

stages:
  ABAP Unit Tests:
    abapEnvironmentRunATCCheck: true
    atcVariant: "DEFAULT"
    abapEnvironmentRunAUnitTest: true
    aUnitResultsFileName: "AUnitResults.xml"

  ATC Check:
    abapEnvironmentRunATCCheck: true
    atcVariant: "Z_CI_VARIANT"
    atcResultsFileName: "ATCResults.xml"

  Build:
    abapEnvironmentBuild: true

  Deploy:
    abapEnvironmentRelease: true
    cfApiEndpoint: "https://api.cf.eu10.hana.ondemand.com"
    cfOrg: "my-org"
    cfSpace: "dev"

┌────────────────────────────────────────────────────────────────┐
│  Credentials Store                                               │
├────────────────────────────────────────────────────────────────┤
│                                                                  │
│  Name: abap-credentials                                         │
│  Type: Basic Authentication                                     │
│  Username: CICD_USER                                            │
│  Password: ********                                             │
│                                                                  │
│  Name: cf-credentials                                           │
│  Type: Cloud Foundry                                            │
│  API Endpoint: https://api.cf.eu10.hana.ondemand.com           │
│  Org: my-organization                                           │
│  Space: dev                                                      │
│                                                                  │
│  Name: git-credentials                                          │
│  Type: SSH Key                                                   │
│  Private Key: ********                                          │
│                                                                  │
└────────────────────────────────────────────────────────────────┘

CLASS zcl_customer_test DEFINITION
  FOR TESTING
  RISK LEVEL HARMLESS
  DURATION SHORT.

  PRIVATE SECTION.
    CLASS-DATA:
      mo_environment TYPE REF TO if_cds_test_environment.

    CLASS-METHODS:
      class_setup,
      class_teardown.

    METHODS:
      setup,
      teardown,
      " Test Methods - klar benannt für CI/CD Reports
      test_create_customer_success FOR TESTING,
      test_create_customer_invalid_email FOR TESTING,
      test_update_customer_status FOR TESTING,
      test_delete_customer_with_orders FOR TESTING.
ENDCLASS.

CLASS zcl_customer_test IMPLEMENTATION.
  METHOD class_setup.
    " CDS Test Double Framework für isolierte Tests
    mo_environment = cl_cds_test_environment=>create_for_multiple_cds(
      VALUE #(
        ( i_for_entity = 'ZI_CUSTOMER' )
        ( i_for_entity = 'ZI_ORDER' )
      )
    ).
  ENDMETHOD.

  METHOD class_teardown.
    mo_environment->destroy( ).
  ENDMETHOD.

  METHOD setup.
    " Testdaten vor jedem Test
    mo_environment->clear_doubles( ).

    " Mock-Daten einfügen
    DATA(lt_customers) = VALUE zt_customer_t(
      ( customer_id = '1' name = 'Test GmbH' email = '[email protected]' status = 'A' )
      ( customer_id = '2' name = 'Demo AG' email = '[email protected]' status = 'I' )
    ).

    mo_environment->insert_test_data( lt_customers ).
  ENDMETHOD.

  METHOD teardown.
    ROLLBACK WORK.
  ENDMETHOD.

  METHOD test_create_customer_success.
    " Given
    DATA(lo_cut) = NEW zcl_customer_service( ).
    DATA(ls_input) = VALUE zs_customer_create(
      name  = 'New Customer'
      email = '[email protected]'
    ).

    " When
    DATA(ls_result) = lo_cut->create_customer( ls_input ).

    " Then
    cl_abap_unit_assert=>assert_not_initial(
      act = ls_result-customer_id
      msg = 'Customer ID should be generated'
    ).
    cl_abap_unit_assert=>assert_equals(
      act = ls_result-status
      exp = 'A'
      msg = 'New customer should be active'
    ).
  ENDMETHOD.

  METHOD test_create_customer_invalid_email.
    " Given
    DATA(lo_cut) = NEW zcl_customer_service( ).
    DATA(ls_input) = VALUE zs_customer_create(
      name  = 'Invalid Customer'
      email = 'not-an-email'
    ).

    " When / Then
    TRY.
        lo_cut->create_customer( ls_input ).
        cl_abap_unit_assert=>fail( 'Exception expected for invalid email' ).
      CATCH zcx_customer_error INTO DATA(lx_error).
        cl_abap_unit_assert=>assert_equals(
          act = lx_error->error_code
          exp = 'INVALID_EMAIL'
        ).
    ENDTRY.
  ENDMETHOD.

  METHOD test_update_customer_status.
    " Given
    DATA(lo_cut) = NEW zcl_customer_service( ).

    " When
    lo_cut->set_customer_status(
      iv_customer_id = '1'
      iv_status      = 'I'
    ).

    " Then
    DATA(ls_customer) = lo_cut->get_customer( '1' ).
    cl_abap_unit_assert=>assert_equals(
      act = ls_customer-status
      exp = 'I'
      msg = 'Status should be updated to inactive'
    ).
  ENDMETHOD.

  METHOD test_delete_customer_with_orders.
    " Given: Kunde mit Bestellungen
    DATA(lo_cut) = NEW zcl_customer_service( ).

    DATA(lt_orders) = VALUE zt_order_t(
      ( order_id = '100' customer_id = '1' amount = 1000 )
    ).
    mo_environment->insert_test_data( lt_orders ).

    " When / Then: Löschen sollte fehlschlagen
    TRY.
        lo_cut->delete_customer( '1' ).
        cl_abap_unit_assert=>fail( 'Exception expected - customer has orders' ).
      CATCH zcx_customer_error INTO DATA(lx_error).
        cl_abap_unit_assert=>assert_equals(
          act = lx_error->error_code
          exp = 'CUSTOMER_HAS_ORDERS'
        ).
    ENDTRY.
  ENDMETHOD.
ENDCLASS.

"! <p class="shorttext">Customer Service Test Coverage</p>
"! @testing ZCL_CUSTOMER_SERVICE
CLASS zcl_customer_test DEFINITION
  FOR TESTING
  RISK LEVEL HARMLESS
  DURATION SHORT.

┌────────────────────────────────────────────────────────────────┐
│  ATC Check Variant: Z_CICD_CHECKS                               │
├────────────────────────────────────────────────────────────────┤
│                                                                  │
│  Priority 1 (Blocker - Pipeline fails):                        │
│  ☑ Syntax Errors                                                │
│  ☑ Security Vulnerabilities (SQL Injection, XSS)               │
│  ☑ Performance Critical (SELECT without WHERE)                 │
│  ☑ Obsolete Statements (not cloud-ready)                       │
│                                                                  │
│  Priority 2 (Warning - Report only):                           │
│  ☑ Naming Conventions                                           │
│  ☑ Code Style                                                   │
│  ☑ Missing Documentation                                        │
│  ☑ Unused Variables                                             │
│                                                                  │
│  Priority 3 (Info - Ignored in CI/CD):                         │
│  ☐ Spelling Suggestions                                         │
│  ☐ Refactoring Opportunities                                   │
│                                                                  │
│  Exemptions:                                                     │
│  - Test Classes (RISK LEVEL, DURATION checks)                  │
│  - Generated Code (SICF handlers)                              │
│                                                                  │
└────────────────────────────────────────────────────────────────┘

CLASS zcl_legacy_wrapper DEFINITION
  PUBLIC FINAL
  CREATE PUBLIC.

  PUBLIC SECTION.
    METHODS: call_legacy_function.
ENDCLASS.

CLASS zcl_legacy_wrapper IMPLEMENTATION.
  METHOD call_legacy_function.
    " ATC Exemption für bewusst genutzten Legacy-Code
    "#EC CI_NOCHECK - Legacy-Integration, Migration geplant Q3
    CALL FUNCTION 'Z_LEGACY_FUNCTION'
      EXPORTING
        iv_input = mv_input.
  ENDMETHOD.
ENDCLASS.

CLASS zcl_api_integration_test DEFINITION
  FOR TESTING
  RISK LEVEL DANGEROUS
  DURATION LONG.

  PRIVATE SECTION.
    METHODS:
      test_odata_service_metadata FOR TESTING,
      test_odata_create_entity FOR TESTING,
      test_odata_error_handling FOR TESTING.
ENDCLASS.

CLASS zcl_api_integration_test IMPLEMENTATION.
  METHOD test_odata_service_metadata.
    " OData Service $metadata abrufen
    DATA(lo_client) = cl_web_http_client_manager=>create_by_http_destination(
      cl_http_destination_provider=>create_by_url(
        i_url = |http://localhost:8080/sap/opu/odata/sap/Z_CUSTOMER_SRV/$metadata|
      )
    ).

    DATA(lo_response) = lo_client->execute( if_web_http_client=>get ).

    cl_abap_unit_assert=>assert_equals(
      act = lo_response->get_status( )-code
      exp = 200
      msg = 'Metadata should be accessible'
    ).

    " Schema validieren
    DATA(lv_metadata) = lo_response->get_text( ).
    cl_abap_unit_assert=>assert_true(
      act = xsdbool( lv_metadata CS 'EntityType Name="Customer"' )
      msg = 'Customer entity should exist in metadata'
    ).

    lo_client->close( ).
  ENDMETHOD.

  METHOD test_odata_create_entity.
    DATA(lo_client) = cl_web_http_client_manager=>create_by_http_destination(
      cl_http_destination_provider=>create_by_url(
        i_url = |http://localhost:8080/sap/opu/odata/sap/Z_CUSTOMER_SRV/CustomerSet|
      )
    ).

    DATA(lo_request) = lo_client->get_http_request( ).
    lo_request->set_header_field( i_name = 'Content-Type' i_value = 'application/json' ).
    lo_request->set_text( '{"Name": "Integration Test", "Email": "[email protected]"}' ).

    DATA(lo_response) = lo_client->execute( if_web_http_client=>post ).

    cl_abap_unit_assert=>assert_equals(
      act = lo_response->get_status( )-code
      exp = 201
      msg = 'Entity should be created'
    ).

    lo_client->close( ).
  ENDMETHOD.

  METHOD test_odata_error_handling.
    DATA(lo_client) = cl_web_http_client_manager=>create_by_http_destination(
      cl_http_destination_provider=>create_by_url(
        i_url = |http://localhost:8080/sap/opu/odata/sap/Z_CUSTOMER_SRV/CustomerSet('INVALID')|
      )
    ).

    DATA(lo_response) = lo_client->execute( if_web_http_client=>get ).

    cl_abap_unit_assert=>assert_equals(
      act = lo_response->get_status( )-code
      exp = 404
      msg = 'Invalid key should return 404'
    ).

    lo_client->close( ).
  ENDMETHOD.
ENDCLASS.

# In der GitHub Actions Pipeline
- name: Notify Slack on Failure
  if: failure()
  uses: slackapi/slack-github-action@v1
  with:
    channel-id: 'C01234567'
    slack-message: |
      :x: *ABAP Pipeline Failed*
      Repository: ${{ github.repository }}
      Branch: ${{ github.ref_name }}
      Commit: ${{ github.sha }}
      Author: ${{ github.actor }}
      <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|View Details>
  env:
    SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}

- name: Notify Slack on Success
  if: success()
  uses: slackapi/slack-github-action@v1
  with:
    channel-id: 'C01234567'
    slack-message: |
      :white_check_mark: *ABAP Pipeline Successful*
      Repository: ${{ github.repository }}
      Branch: ${{ github.ref_name }}
      Deployed to: ${{ matrix.environment }}
  env:
    SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}

- name: Generate Test Report
  run: |
    cat << EOF > test-report.md
    # ABAP Test Report

    **Build:** ${{ github.run_number }}
    **Date:** $(date -u +"%Y-%m-%d %H:%M:%S UTC")
    **Branch:** ${{ github.ref_name }}

    ## Unit Tests
    - Total: $(grep -c 'testmethod' aunit_results.xml || echo "0")
    - Passed: $(grep -c 'type="success"' aunit_results.xml || echo "0")
    - Failed: $(grep -c 'type="failure"' aunit_results.xml || echo "0")

    ## Code Coverage
    - Statement: ${{ steps.coverage.outputs.statement }}%
    - Branch: ${{ steps.coverage.outputs.branch }}%

    ## ATC Findings
    - Errors: $(grep -c 'priority="1"' atc_results.xml || echo "0")
    - Warnings: $(grep -c 'priority="2"' atc_results.xml || echo "0")
    - Info: $(grep -c 'priority="3"' atc_results.xml || echo "0")
    EOF

- name: Upload Test Report
  uses: actions/upload-artifact@v4
  with:
    name: test-report
    path: test-report.md